add method to create a party + lobby dto #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements lobby creation functionality for the duel/party system, enabling users to create lobbies with unique join codes that other players can use to join games.
Key Changes:
- Introduced
PartyCodeGeneratorutility for generating 6-character alphanumeric join codes with collision detection - Added
LobbyDtofor structured lobby data transfer - Implemented the
createPartyendpoint inDuelControllerthat creates a lobby and associates the creator as the first player
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
PartyCodeGenerator.java |
New utility class for generating unique random party codes with configurable retry logic |
LobbyDto.java |
New DTO that maps Lobby entities to API response format with all relevant fields |
DuelController.java |
Added createParty endpoint with authentication, duplicate lobby checks, and lobby/player creation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/patina/codebloom/common/util/PartyCodeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/common/util/PartyCodeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/api/duel/DuelController.java
Outdated
Show resolved
Hide resolved
Contributor
|
Contributor
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/patina/codebloom/common/util/PartyCodeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/api/duel/DuelController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/api/duel/DuelController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/api/duel/DuelController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/common/util/PartyCodeGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/patina/codebloom/common/util/PartyCodeGenerator.java
Outdated
Show resolved
Hide resolved
angelayu0530
force-pushed
the
create-party
branch
from
3a9c560 to
516cfe4
Compare
Contributor
|
Arshadul-Monir
previously approved these changes
Nov 7, 2025
tahminator
reviewed
Nov 7, 2025
src/main/java/com/patina/codebloom/common/utils/duel/PartyCodeGenerator.java
Show resolved
Hide resolved
tahminator
requested changes
Nov 7, 2025
src/main/java/com/patina/codebloom/api/duel/DuelController.java
Outdated
Show resolved
Hide resolved
angelayu0530
force-pushed
the
create-party
branch
from
266001c to
0e50608
Compare
Contributor
|
Contributor
|
angelayu0530
force-pushed
the
create-party
branch
from
d3ca19d to
29aad3d
Compare
Contributor
|
Contributor
|
Contributor
|
tahminator
approved these changes
Nov 10, 2025
a random code generator
Update src/main/java/com/patina/codebloom/api/duel/DuelController.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> nits
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tahminator
force-pushed
the
create-party
branch
from
b6a2ee1 to
31da6bc
Compare
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-created a joincode generator ( will be replaced later)